Changed sha1 into bcrypt #3356
Closed
Changed sha1 into bcrypt #3356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1358,6 +1358,15 @@ the password is simply run through the ``sha1`` algorithm one time and without | |||
| any extra encoding. You can now calculate the hashed password either programmatically | |||
| (e.g. ``hash('sha1', 'ryanpass')``) or via some online tool like `functions-online.com`_ | |||
|
|
|||
| .. caution:: | |||
|
|
|||
| The above example is not meaned for practical usage, it uses a weak hash | |||
There was a problem hiding this comment.
I left the above example with sha1, because when using bcrypt it would be hard to get the hashed password.
|
A larger change to the docs may be more suitable for the reader. For example we could move this section to be entirely on use of bcrypt and add an extra page elsewhere that describe pbkdf2 usage, and we can group "legacy hashing" algos like MD5, Rot13, Sha1, etc. |
|
You should add a note about the requirements somewhere. To use the BCrypt encoder, you need to upgrade to PHP 5.5 or install the "ircmaxell/password-compat" via Composer ... see BCryptPasswordEncoder |
weaverryan
added a commit
that referenced
this pull request
Jan 2, 2014
… details in intro area that aren't necessary (you'll need to read the cookbook entry for more details anyways)
weaverryan
added a commit
that referenced
this pull request
Jan 2, 2014
Also removing one example (now possible with using bcrypt from the beginning) and related tweaks.
weaverryan
added a commit
that referenced
this pull request
Jan 2, 2014
weaverryan
added a commit
that referenced
this pull request
Jan 2, 2014
Also filling in other details related to using BCrypt
|
Thanks for starting with Wouter! I've continued the conversation with a new PR at #3405 with some additional changes. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We loose some information, but I don't think that information is necessary. I also made the change without testing it, so: Needs some review!
/cc @ircmaxell @weaverryan